Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/pkgs/pip: Increase lower version bound; upgrade pip, wheel, packaging, platformdirs #36540

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 25, 2023

... to fix opensuse-15.5-gcc_11-python3.11-sitepackages https://github.com/mkoeppe/sage/actions/runs/6622955701/job/18026350285

 [pillow-10.0.1]   Usage:   
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-python3.11/bin/python3 -m pip wheel [options] <requirement specifier> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-python3.11/bin/python3 -m pip wheel [options] -r <requirements file> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-python3.11/bin/python3 -m pip wheel [options] [-e] <vcs project url> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-python3.11/bin/python3 -m pip wheel [options] [-e] <local project path> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-python3.11/bin/python3 -m pip wheel [options] <archive url/path> ...
  [pillow-10.0.1]   
  [pillow-10.0.1]   no such option: -C
  [pillow-10.0.1]   Warning: building with "python3 -m pip wheel --wheel-dir=dist --verbose --no-deps --no-index --isolated --ignore-requires-python --find-links=/sage/local/var/lib/sage/venv-python3.11/var/lib/sage/wheels" failed.
  [pillow-10.0.1]   Retrying with "python3 -m pip wheel --wheel-dir=dist --verbose --no-deps --no-index --isolated --ignore-requires-python --no-build-isolation --no-binary :all:".
  [pillow-10.0.1]   

(first reported in #36536)

Prompted by looking at changelogs of related packages, we update a few:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 5db8ca8; changes) is ready! 🎉

@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 27, 2023
@orlitzky
Copy link
Contributor

Lots of unrelated(?) test failures:

Expected nothing
Got:
WARNING setuptools_scm._integration.setuptools pyproject.toml does not contain a tool.setuptools_scm section

Might already be fixes in setuptools_scm: pypa/setuptools-scm#938

If you think it's unrelated, this LGTM. pip-23.1.0 is old enough that I don't think we should bother trying to use --config-settings instead.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2023

Yes, that is unrelated and fixed in #36552

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2023

pip-23.1.0 is old enough that I don't think we should bother trying to use --config-settings instead.

Yes, that agrees with my thinking.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2023

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 28, 2023
…rade `pip`, `wheel`, `packaging`, `platformdirs`

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
... to fix `opensuse-15.5-gcc_11-python3.11-sitepackages`
https://github.com/mkoeppe/sage/actions/runs/6622955701/job/18026350285
```
 [pillow-10.0.1]   Usage:
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] <requirement specifier>
...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] -r <requirements file> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] [-e] <vcs project url> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] [-e] <local project path>
...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] <archive url/path> ...
  [pillow-10.0.1]
  [pillow-10.0.1]   no such option: -C
  [pillow-10.0.1]   Warning: building with "python3 -m pip wheel
--wheel-dir=dist --verbose --no-deps --no-index --isolated --ignore-
requires-python --find-links=/sage/local/var/lib/sage/venv-
python3.11/var/lib/sage/wheels" failed.
  [pillow-10.0.1]   Retrying with "python3 -m pip wheel --wheel-dir=dist
--verbose --no-deps --no-index --isolated --ignore-requires-python --no-
build-isolation --no-binary :all:".
  [pillow-10.0.1]
```
(first reported in sagemath#36536)

Prompted by looking at changelogs of related packages, we update a few:
- https://pip.pypa.io/en/stable/news/

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36540
Reported by: Matthias Köppe
Reviewer(s): Michael Orlitzky
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 29, 2023
…rade `pip`, `wheel`, `packaging`, `platformdirs`

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
... to fix `opensuse-15.5-gcc_11-python3.11-sitepackages`
https://github.com/mkoeppe/sage/actions/runs/6622955701/job/18026350285
```
 [pillow-10.0.1]   Usage:
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] <requirement specifier>
...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] -r <requirements file> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] [-e] <vcs project url> ...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] [-e] <local project path>
...
  [pillow-10.0.1]     /sage/local/var/lib/sage/venv-
python3.11/bin/python3 -m pip wheel [options] <archive url/path> ...
  [pillow-10.0.1]
  [pillow-10.0.1]   no such option: -C
  [pillow-10.0.1]   Warning: building with "python3 -m pip wheel
--wheel-dir=dist --verbose --no-deps --no-index --isolated --ignore-
requires-python --find-links=/sage/local/var/lib/sage/venv-
python3.11/var/lib/sage/wheels" failed.
  [pillow-10.0.1]   Retrying with "python3 -m pip wheel --wheel-dir=dist
--verbose --no-deps --no-index --isolated --ignore-requires-python --no-
build-isolation --no-binary :all:".
  [pillow-10.0.1]
```
(first reported in sagemath#36536)

Prompted by looking at changelogs of related packages, we update a few:
- https://pip.pypa.io/en/stable/news/

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36540
Reported by: Matthias Köppe
Reviewer(s): Michael Orlitzky
@vbraun vbraun merged commit c8299c7 into sagemath:develop Oct 31, 2023
23 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants