-
-
Notifications
You must be signed in to change notification settings - Fork 673
Use SAGE_DOC_SRC instead of relative path in docbuilder test #40895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 3de32dc; changes) is ready! 🎉 |
How do you run into this issue? I.e. why do you have the sage_doctest folder around but not src/doc? |
@tobiasdiez Yes, you're right. The problem with the new tests is something else: Before, the paths in the relevant tests were prefixed by |
d652acf
to
3e86107
Compare
No this was indeed not intended. Thanks for bringing this up and providing a fix! One small suggestion from my side, otherwise it's good to go. |
3e86107
to
a53eb7a
Compare
Fixed. Thanks for the review! |
a53eb7a
to
3de32dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI issues seem to be unrelated.
These two
sage_docbuild
tests use a relative path, requiringsage -t --all
to be run from a specific directory. This was never needed before, so perhaps it was unintended.