-
-
Notifications
You must be signed in to change notification settings - Fork 673
switch to n_vertices, n_edges and n_faces for graphs #40918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
I did not touch the method names in the graph backends. Should I change them and add aliases for consistency? |
Documentation preview for this PR (built with commit 57156ca; changes) is ready! 🎉 |
Yes, that would be better. Thanks. |
There are about 50 files in total that use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
changes in the codebase can be done in future PR if needed.
Thanks.
Thank you! Small request: could you (and @fchapoton, and whoever else might be interested) please make a decision. It would be easier for me to do it now (happily in a different PR) than in a few weeks. |
For the graph module (at least), yes you can do changes in the codebase as well. We have the aliases for compatibility. Thanks. |
This provides aliases
n_vertices
,n_edges
andn_faces
, and uses them throughout the docstringEXAMPLES
.The old aliases
num_verts
,num_edges
andnum_faces
are kept. Also, they are kept in the code base, to avoid touching too many files.