-
-
Notifications
You must be signed in to change notification settings - Fork 674
Make tests pass with GAP 4.15 #40919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 016b977; changes) is ready! 🎉 |
Not sure if you addressed this already, but it seems that some tests are now really slow:
|
By "now" do you mean with GAP 4.15? This PR only changes the expected output of some tests |
Yes, sorry, I should have been more clear. The test I mentioned seems to be a lot slower on GAP 4.15 than it was on GAP 4.14. More specifically, testing |
Indeed. I have reported it upstream at gap-system/gap#6135 |
Tests are passing now with GAP 4.14 and 4.15 modulo the upstream bugs gap-system/gap#6133 and gap-system/gap#6135, ready for review |
GAP 4.15 causes a few test failures caused mostly by different ordering of group characters and different elements returned for
an_element
in group algebras, make test pass with both old and new versions.