fix: delayed load of darklightswitch and pagefind icons #725
+183
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoeyC-Dev is attempting to deploy a commit to the zephyirdgmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
The issue only occurs when there are two themes for expressive code. Signed-off-by: Joey Chen <142381267+JoeyC-Dev@users.noreply.github.com>
Signed-off-by: Joey Chen <142381267+JoeyC-Dev@users.noreply.github.com> fix: astro check issue
CMSZ001
pushed a commit
to CMSZ001/fuwari
that referenced
this pull request
Feb 9, 2026
- 将搜索栏和主题切换按钮移至 Astro 组件以实现即时渲染 - 预加载关键图标以消除 CDN 请求延迟 - 将 Pagefind 脚本加载逻辑移至主布局，减少重复代码 - 通过 data-theme-mode 属性同步主题状态，避免样式闪烁 - [#725](saicaca/fuwari#725)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist
Related Issue
Fix: #724
Changes
Layout.astrohead to setdata-theme-modeattribute before renderingNavbar.astroLayout.astroclient:onlytoclient:loadSearch.sveltenow only renders search panel, connects to Astro elements viaonMountLightDarkSwitch.sveltenow only renders dropdown panel, wires up events viaonMountmodulepreloadhint for parallel fetching@iconify-jsonpackages usingaddIcon()in Svelte componentsHow To Test
Use Slow 4G mode to check if the pagefind and LightDarkSwitch icons are being loaded together with Navbar.
Screenshots (if applicable)
(Caption: It is now showing with navbar.)
Additional Notes
The following files provided via CDN have sizes of 1.3 KB and 0.9 KB: (external CDN itself will cause delay)
I don't think there is any need for these files to be loaded from CDN. So I removed them.