Skip to content

Commit

Permalink
- Chart version bump (#99)
Browse files Browse the repository at this point in the history
- Rename GitLab file name suffix from pr to mr, this correctly names the suffix to merge request (mr)
- Add AppSet name as suffix to GitLab app name
- Add AppSet name as suffix to GitHub app name
- Add changelog entries

These changes allow us to deploy multiple applications that will not have name collision.

Closes: #100

Signed-off-by: Said Sef <saidsef@gmail.com>
  • Loading branch information
saidsef authored Apr 21, 2023
1 parent 95ed6d2 commit 2f884a8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions charts/applicationset/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: argocd-applicationsets-services
description: A HELM Chart for ArgoCD ApplicationSets for Kubernetes
type: application
version: &version "0.8.25"
version: &version "0.9.1"
appVersion: *version
kubeVersion: ">= 1.23"
home: https://github.com/saidsef/argocd-applicationsets-services
Expand All @@ -23,7 +23,9 @@ annotations:
artifacthub.io/license: "Apache-2.0"
artifacthub.io/changes: |
- kind: changed
description: Updated GitLab repoURL to also include GitLan API override
description: Updated to add AppSet name as suffix to GitHub and GitLab App names
- kind: changed
description: Renamed GitLab file from pr to mr as suffix
artifacthub.io/links: |
- name: README
url: https://raw.githubusercontent.com/saidsef/argocd-applicationsets-services/main/README.md
Expand Down
2 changes: 1 addition & 1 deletion charts/applicationset/templates/github-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
name: '{{ required "A valid repo name is required" $repo.name }}-github'
name: '{{ required "A valid repo name is required" $repo.name }}-github-{{ $name }}'
namespace: {{ required "A valied namespace is required" $namespace | replace "." "-" }}
labels:
app.kubernetes.io/name: {{ $repo.name }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
name: '{{ required "A valid repo name is required" $repo.name }}-gitlab'
name: '{{ required "A valid repo name is required" $repo.name }}-gitlab-{{ $name }}'
namespace: {{ required "A valied namespace is required" $namespace | replace "." "-" }}
labels:
app.kubernetes.io/name: {{ $repo.name }}
Expand Down

0 comments on commit 2f884a8

Please sign in to comment.