Skip to content

Commit

Permalink
feat: Added appset information to GitHub and GitLab PRs (#190)
Browse files Browse the repository at this point in the history
* feat: Added appset information to GitHub and GitLab PRs

* fix: ci add pull requst write to dep review
  • Loading branch information
saidsef authored Dec 29, 2024
1 parent 37e5c46 commit 45138d6
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 6 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/charts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ jobs:
uses: saidsef/saidsef/.github/workflows/dependency-review.yaml@main
if: ${{ github.event_name == 'pull_request' }}
needs: [chart]
permissions:
pull-requests: write

k8s-test:
runs-on: ubuntu-latest
Expand All @@ -109,8 +111,8 @@ jobs:
- name: Create k8s Kind Cluster
uses: helm/kind-action@v1.12.0
with:
kubectl_version: v1.29.3 # Ensure compatibility with the latest APIs
node_image: kindest/node:v1.29.2 # Match node version with kubectl for consistency
kubectl_version: v1.30.4 # Ensure compatibility with the latest APIs
node_image: kindest/node:v1.30.4 # Match node version with kubectl for consistency
- name: Checkout
uses: actions/checkout@v4
- name: Run K8s test
Expand Down
6 changes: 2 additions & 4 deletions charts/applicationset/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: argocd-applicationsets-services
description: A Helm chart for ArgoCD ApplicationSets, a declarative, GitOps continuous delivery tool for Kubernetes
type: application
version: &version "0.14.0"
version: &version "0.15.0"
appVersion: *version
kubeVersion: ">= 1.28"
home: https://github.com/saidsef/argocd-applicationsets-services
Expand All @@ -24,9 +24,7 @@ annotations:
artifacthub.io/license: "Apache-2.0"
artifacthub.io/changes: |
- kind: added
description: ability to add extra annotations via values file
- kind: changed
description: updated helm readme file
description: Added appset information to GitHub and GitLab PRs
artifacthub.io/links: |
- name: README
url: https://raw.githubusercontent.com/saidsef/argocd-applicationsets-services/main/README.md
Expand Down
9 changes: 9 additions & 0 deletions charts/applicationset/templates/github-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,14 @@ spec:
server: {{ $server }}
{{- end }}
namespace: {{ coalesce $repo.namespace $.Values.globals.deployToNamespace (printf "mr-%sbranch_slug%s-%snumber%s" $dqf $dqb $dqf $dqb) }}
info:
- name: author
value: '{{ $dqf }}author{{ $dqb }}'
- name: branch
value: '{{ $dqf }}branch{{ $dqb }}'
- name: target_branch
value: '{{ $dqf }}target_branch_slug{{ $dqb }}'
- name: pull_request
value: '{{ $dqf }}number{{ $dqb }}'
{{- end }}
{{- end }}
9 changes: 9 additions & 0 deletions charts/applicationset/templates/gitlab-mr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,14 @@ spec:
server: {{ $server }}
{{- end }}
namespace: {{ coalesce $repo.namespace $.Values.globals.deployToNamespace (printf "mr-%sbranch_slug%s-%snumber%s" $dqf $dqb $dqf $dqb) }}
info:
- name: author
value: '{{ $dqf }}author{{ $dqb }}'
- name: branch
value: '{{ $dqf }}branch{{ $dqb }}'
- name: target_branch
value: '{{ $dqf }}target_branch_slug{{ $dqb }}'
- name: merge_request
value: '{{ $dqf }}number{{ $dqb }}'
{{- end }}
{{- end }}

0 comments on commit 45138d6

Please sign in to comment.