Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OpenTofu test to CI workflows #48

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

saidsef
Copy link
Owner

@saidsef saidsef commented Jan 5, 2025

@saidsef saidsef added the enhancement New feature or request label Jan 5, 2025
@saidsef saidsef self-assigned this Jan 5, 2025
@saidsef saidsef force-pushed the opentofu-gh-pipeline branch from 108f5b7 to 34cdd4e Compare January 5, 2025 09:48
github-actions[bot]
github-actions bot previously approved these changes Jan 5, 2025
This in-place OpenTofu Pipeline will validate module against OpenTofu version ranges
@saidsef
Copy link
Owner Author

saidsef commented Jan 5, 2025

/code pr

Copy link
Owner Author

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Review of .github/workflows/ci.yaml Modifications

  1. Separation of Jobs:

    • The validate job has been split into terraform and opentofu, which is clear and explicit in the testing of both Terraform and OpenTofu. This separation likely aids in maintaining distinct validation steps for each tool.
  2. Addition of OpenTofu Job:

    • The introduction of the opentofu job is well-organised and correctly integrates with the workflow. The use of uses indicates reliance on a reusable workflow, which promotes reusability.
    • Specifying version ranges (start-version and end-version) follows the current Terraform validation setup, maintaining consistency across jobs.
  3. Dependency Updates:

    • Updating the needs field to include new dependencies (terraform and opentofu) in subsequent jobs is necessary and has been correctly done. Ensuring that tfsec, caller-identity-check, and auto-approve depend on both maintains the required sequence.
  4. Overall Workflow Structure:

    • The refactoring and additions preserve the integrity of the CI workflow and enhance its capability without introducing complexity.

Suggestions:

  • Consider adding comments or documentation to explain the reasoning behind specific version ranges (start-version and end-version) for better maintainability and understanding by future contributors.
  • Ensure thorough testing of the new opentofu job to verify that the expected OpenTofu features are effectively validated within the specified version bounds.

> gpt-4o [pr | 1]

@saidsef saidsef merged commit 59c47aa into main Jan 5, 2025
26 checks passed
@saidsef saidsef deleted the opentofu-gh-pipeline branch January 5, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant