-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Sailfish.Pickers.FolderPickerPage to configure music directories #33
Use Sailfish.Pickers.FolderPickerPage to configure music directories #33
Conversation
@smokku, thank you very much for this and your other contribution (MR #34). Sorry for the long delay, I was knocked-out by influenza etc. from early December until mid January and now I am trying to catch up with my backlog at work, private stuff and last, but not least SFOS-related stuff. Note that FlowPlayer's code-base currently supports all releases since 1.1.9 (maybe even 1.1.7), that the GitHub CI workflow compiles for some releases starting with 2.2.0 and that SailfishOS Chum supports all releases since 3.1.0. Thus a mechanism for different code paths to target different SFOS releases has to be employed, before merging this PR.
I consider implementing the second scheme some day, unless someone (you?) poses a merge request with some (e.g. the first) approach meanwhile. In the latter case, I just have to review, which should be done quicker. Either way it is necessary to know the exact SailfishOS release, which introduced a change; because this is the minimal release for which switching the code ("… base", when using the second, simpler approach) is feasible. This documentation can be helpful for researching these. Please reference the source(s) of this information by web-links, when providing the result of this research here. |
Fallback to old code if the Sailfish.Pickers module is not available in the import path.
Fine with me. 👍 |
BTW, I squash-merge feature-branches by default, unless there is a reason not to, e.g. separate commits provide some kind of clarity to a reader later on. Here, I would sure squash-merge by all technical aspects, but that obfuscates that there were two different contributors (i.e. a social aspect). Well, I can name you in the commit message, if I do not forget to. Will review and (likely) merge tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @Olf0 , no problem to loose the ownership of changes on the few lines I modified. That's fair that the commit stay with smokku authorship. He had the idea and proposed the core of the changes. |
Replaces custom AddFolder dialog with Sailfish FolderPickerPage.
Should help resolve #26 confusion.