feat: add options for custom password hashing/verifying functions #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR proposes to move the hash generation and verification to separate functions and allow them to be overridden by the users via the new options
generatePasswordHashAsyncandverifyPasswordHashAsync. This makes it possible to use alternative hash functions (e.g., argon2), while the default behaviour is not changed and backwards-compatible. I also removed the "scmp" package and replaced it with the nativecrypto.timingSafeEqualfunction.Please let me know the chances of this change being merged, I am happy to address any code reviews or feedback!
This should fix issues like #271, #298