Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize attendance tool backend #109

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

davidpbauer
Copy link
Collaborator

Migrate from hbm xml to JPA annotations
Reduce bloat from data model
Reorganize api packages
Remove stats from the database
Remove stats calc job
Add ignite caches

@davidpbauer
Copy link
Collaborator Author

Ignite contrib caches for Sakai 23 - sakaiproject/sakai#10808

@davidpbauer
Copy link
Collaborator Author

This is working well for me locally now. I'm not sure why the maven build is failing on github...

Can someone else take a look at these changes and let me know what you think?

I plan to move on to updating the UI to better match the rest of Sakai once this is merged.

@ottenhoff
Copy link
Contributor

do you need to have sakai kernel in pom.xml?

Comment on lines 81 to 109
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || Hibernate.getClass(this) != Hibernate.getClass(o)) return false;
AttendanceEvent that = (AttendanceEvent) o;
return id != null && Objects.equals(id, that.id);
}

@Override
public int hashCode() {
return getClass().hashCode();
}

@Override
public String toString() {
return getClass().getSimpleName() + "(" +
"id = " + id + ", " +
"name = " + name + ", " +
"startDateTime = " + startDateTime + ")";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use lombok to generate these overridden implementations

Migrate from hbm xml to JPA annotations
Reduce bloat from data model
Reorganize api packages
Remove stats from the database
Remove stats calc job
Add ignite caches
This also addresses sakaicontrib#76 by converting to use sakai's datepicker
@ottenhoff
Copy link
Contributor

Is this PR still relevant?

@ottenhoff
Copy link
Contributor

These changes all look good @davidpbauer .... can we grab what you're running from a UD branch?

@davidpbauer
Copy link
Collaborator Author

Hi Sam. This work never made it to production at UD due to the timing of it, but this branch now has the most up-to-date version of our changes and is testing well locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants