-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize attendance tool backend #109
base: master
Are you sure you want to change the base?
Modernize attendance tool backend #109
Conversation
Ignite contrib caches for Sakai 23 - sakaiproject/sakai#10808 |
This is working well for me locally now. I'm not sure why the maven build is failing on github... Can someone else take a look at these changes and let me know what you think? I plan to move on to updating the UI to better match the rest of Sakai once this is merged. |
do you need to have sakai kernel in pom.xml? |
public boolean equals(Object o) { | ||
if (this == o) return true; | ||
if (o == null || Hibernate.getClass(this) != Hibernate.getClass(o)) return false; | ||
AttendanceEvent that = (AttendanceEvent) o; | ||
return id != null && Objects.equals(id, that.id); | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return getClass().hashCode(); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return getClass().getSimpleName() + "(" + | ||
"id = " + id + ", " + | ||
"name = " + name + ", " + | ||
"startDateTime = " + startDateTime + ")"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use lombok to generate these overridden implementations
Migrate from hbm xml to JPA annotations Reduce bloat from data model Reorganize api packages Remove stats from the database Remove stats calc job Add ignite caches
This also addresses sakaicontrib#76 by converting to use sakai's datepicker
Dependencies
73bf597
to
ab86c33
Compare
Is this PR still relevant? |
These changes all look good @davidpbauer .... can we grab what you're running from a UD branch? |
Hi Sam. This work never made it to production at UD due to the timing of it, but this branch now has the most up-to-date version of our changes and is testing well locally. |
Migrate from hbm xml to JPA annotations
Reduce bloat from data model
Reorganize api packages
Remove stats from the database
Remove stats calc job
Add ignite caches