Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49165 Portal site header should include links to parent sites #13286

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

ottenhoff
Copy link
Contributor

@ottenhoff ottenhoff commented Feb 6, 2025

Screenshot 2025-02-06 at 3 01 07 PM

@kunaljaykam
Copy link
Member

Are all the levels on the breadcrumb is required, its looks bit crowded to me? and what about smaller devices?

@ottenhoff
Copy link
Contributor Author

Are all the levels on the breadcrumb is required, its looks bit crowded to me?

This is the most extreme set of parent sites i've ever seen. i think just one is the most common use case.

and what about smaller devices?

it doesn't appear at all on smaller devices

@adrianfish
Copy link
Contributor

@ottenhoff It's a good question though. How does it wrap if long site names are used? Do you clip the site name, or just let it wrap?

@ottenhoff
Copy link
Contributor Author

ottenhoff commented Feb 11, 2025

It wraps. Same behavior as current.

Note that I'd love to see this feature disappear. I think truly hiding it by default makes the most sense. Legacy users can continue to use it by setting a property. This is a classic 1% user feature

@adrianfish
Copy link
Contributor

@ottenhoff Totally agree. 1% user feature.

Copy link
Contributor

@adrianfish adrianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@ottenhoff ottenhoff merged commit 49e8fc5 into sakaiproject:master Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants