Set fixed date and switch to median for consistent calculations and reliable tests #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the database processing logic to use the median instead of the average for hotel price calculations, supporting both PostgreSQL and SQLite. Introduced dialect-specific handling for efficient median computation and adjusted table creation functions accordingly.
Replaced dynamic `datetime.today()` with a fixed date to ensure consistent and reproducible test behavior. Updated function calls and date formatting to align with the fixed date usage. This improves test reliability and avoids issues caused by date-related variability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
datetime.today()with a fixed date for consistent test behavior.Impact: