Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset tax rate to 0 if taxable amount is zero #1726

Merged
merged 1 commit into from
Feb 5, 2025
Merged

reset tax rate to 0 if taxable amount is zero #1726

merged 1 commit into from
Feb 5, 2025

Conversation

lkostrowski
Copy link
Member

Scope of the PR

Related issues

Checklist

@lkostrowski lkostrowski requested a review from a team as a code owner February 5, 2025 10:21
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 10:26am

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 1f93dab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-avatax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.05%. Comparing base (a10a0ce) to head (1f93dab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1726   +/-   ##
=======================================
  Coverage   44.05%   44.05%           
=======================================
  Files         643      643           
  Lines      296095   296107   +12     
  Branches     2001     2003    +2     
=======================================
+ Hits       130445   130457   +12     
  Misses     165244   165244           
  Partials      406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkostrowski lkostrowski merged commit 899a057 into main Feb 5, 2025
29 checks passed
@lkostrowski lkostrowski deleted the EXT-1779 branch February 5, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants