Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR #1728

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Add ADR #1728

merged 1 commit into from
Feb 7, 2025

Conversation

lkostrowski
Copy link
Member

Scope of the PR

Related issues

Checklist

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:46am

@lkostrowski lkostrowski requested a review from a team as a code owner February 7, 2025 09:41
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 1e27441

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.05%. Comparing base (c1c67d9) to head (1e27441).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1728   +/-   ##
=======================================
  Coverage   44.05%   44.05%           
=======================================
  Files         643      643           
  Lines      296107   296107           
  Branches     2003     2003           
=======================================
  Hits       130457   130457           
  Misses     165244   165244           
  Partials      406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkostrowski lkostrowski merged commit 230fb06 into main Feb 7, 2025
29 of 31 checks passed
@lkostrowski lkostrowski deleted the adr branch February 7, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants