W-14071255: mark null-value datapoints as absent

salesforce · Sep 8, 2023 · 4032a7b · 4032a7b
1 parent fc4ba71
commit 4032a7b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/...ervice/src/main/java/com/demandware/carbonj/service/engine/GraphiteSeriesDataServlet.java b/...ervice/src/main/java/com/demandware/carbonj/service/engine/GraphiteSeriesDataServlet.java
@@ -170,8 +170,15 @@ else if ( protobuf )
                 {
                     LOG.info( String.format( "carbonapi request: found value [%s]",
                         ( value == null ? "null" : (double) value ) ) );
-                    metricsSeriesBuilder = metricsSeriesBuilder
-                        .addValues( value == null ? "null" : String.format( "%d", value ) ).addIsAbsent( false );
+                    if ( value == null )
+                    {
+
+                        metricsSeriesBuilder = metricsSeriesBuilder.addIsAbsent( true );
+                    }
+                    else
+                    {
+                        metricsSeriesBuilder = metricsSeriesBuilder.addValues( value ).addIsAbsent( false );
+                    }
                 }
 
                 MetricsResponse.Series metricsSeries = metricsSeriesBuilder.build();

diff --git a/carbonj.service/src/main/protobuf/MetricsResponse.proto b/carbonj.service/src/main/protobuf/MetricsResponse.proto
@@ -15,7 +15,7 @@ message Series {
    required int32 start = 2;
    required int32 end = 3;
    required int32 step = 4;
-   repeated boolean values = 5;
+   repeated double values = 5;
    repeated bool isAbsent = 6;
 }