W-16656937: add graphite.prefix.includeHostname property #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdmoineau
force-pushed
the
pmoineau.W-16656937.graphite-prefix
branch
2 times, most recently
from
de9c175
to
8ab9b4d
Compare
pdmoineau
changed the title
pdmoineau
force-pushed
the
pmoineau.W-16656937.graphite-prefix
branch
from
8ab9b4d
to
e3ec850
Compare
peterzxu-crm
previously approved these changes
Sep 11, 2024
| @@ -24,8 +24,8 @@ public class Util | |||
|
|
|||
| private static GraphiteReporter graphiteReporter = null; | |||
|
|
|||
| public static String getGraphiteMetricPrefix( String graphiteMetricsPrefix, int podId, String groupId, | |||
There was a problem hiding this comment.
Is it possible to add unit test for this ?
There was a problem hiding this comment.
I added a unit test
pdmoineau
force-pushed
the
pmoineau.W-16656937.graphite-prefix
branch
from
55f3862
to
277d8bd
Compare
peterzxu-crm
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graphite.prefix.includeHostname adds support for a custom prefix that includes the hostname.