Skip to content

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Sep 26, 2025

Details

  1. Integration tests run by default in synthetic shadow, while hydration tests run by default in native shadow. There were quasi-duplicate env vars, DISABLE_SYNETHETIC (integration) and ENABLE_SYNTHETIC_SHADOW_IN_HYDRATION (hydration). They weren't set up quite right, so I fixed them. And then I consolidated them into a single env var, SHADOW_MODE_OVERRIDE. This required a minor shuffling around of options so that NATIVE_SHADOW could be set with the correct default value in each test suite.
  2. I updated a handful of tests, so now all tests pass in both native and synthetic shadow modes.
  3. I updated CI so that integration and hydration tests run in native and synthetic shadow modes, and CI will fail if the other tests fail.
  4. I added all env vars modes to CI. The ones not specified above are just informational, if they fail then CI will still pass.
    a. This makes CI take ~35 minutes, but that's still shorter than nucleus, so it shouldn't be too much of a slowdown. I'm also actively working on this, and I will eventually parallelize test runs so that we stay close to the current ~15 minutes.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

Comment on lines +55 to +56
testConfig = (await import(configPath)).default;
Component = (await import(componentPath)).default;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! We were using the wrong object, so none of the tests were actually executing. Fortunately, all the tests are still passing with this fixed. I added the else clause below to prevent this accident from happening again.

@wjhsf wjhsf changed the title test(wtr): run all the flavors and see what happens test(wtr): run integration tests in native and synthetic shadow modes @W-19098130 Sep 26, 2025
@wjhsf wjhsf marked this pull request as ready for review September 26, 2025 18:48
@wjhsf wjhsf requested a review from a team as a code owner September 26, 2025 18:48
@wjhsf wjhsf merged commit 9223fc6 into master Sep 30, 2025
10 checks passed
@wjhsf wjhsf deleted the wjh/wtr-env-vars branch September 30, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants