-
Notifications
You must be signed in to change notification settings - Fork 422
test(wtr): run integration tests in native and synthetic shadow modes @W-19098130 #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they weren't actually running before 😰
This reverts commit 0c81acb.
…t shadow modes they were supposed to all along, but it was implemented incorrectly
wjhsf
commented
Sep 26, 2025
Comment on lines
+55
to
+56
testConfig = (await import(configPath)).default; | ||
Component = (await import(componentPath)).default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! We were using the wrong object, so none of the tests were actually executing. Fortunately, all the tests are still passing with this fixed. I added the else clause below to prevent this accident from happening again.
also make john fix it later
jhefferman-sfdc
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
DISABLE_SYNETHETIC
(integration) andENABLE_SYNTHETIC_SHADOW_IN_HYDRATION
(hydration). They weren't set up quite right, so I fixed them. And then I consolidated them into a single env var,SHADOW_MODE_OVERRIDE
. This required a minor shuffling around of options so thatNATIVE_SHADOW
could be set with the correct default value in each test suite.a. This makes CI take ~35 minutes, but that's still shorter than nucleus, so it shouldn't be too much of a slowdown. I'm also actively working on this, and I will eventually parallelize test runs so that we stay close to the current ~15 minutes.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item