chore: promote-verify changes #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this fixed it https://github.com/salesforcecli/cli/actions/runs/6724766082 I think it has to do with proxy issues with |
iowillhoit
commented
Nov 1, 2023
| @@ -104,11 +106,17 @@ banner "Verify tarball install and that 'sf update $NEW_CHANNEL' version matches | |||
| # If you are testing this locally, you'll need to use a tarball built for your OS | |||
| # There is a VERSIONS_URL for M1 macs above that you can uncomment | |||
| # Other URLs can be found here: https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_install_cli.htm#sfdx_setup_install_cli_olderversions | |||
| OLDER_VERSION_URL=$(echo "$VERSION_CONTENT" | jq 'to_entries[7]' | jq -r '.value') | |||
| OLDER_VERSION_URL=$(echo "$VERSION_CONTENT" | jq 'to_entries[15]' | jq -r '.value') | |||
There was a problem hiding this comment.
This change is to grab a version older than stable. With nightly builds we were grabbing a newer version at index 7
iowillhoit
commented
Nov 1, 2023
| rm -rf "$HOME/sf" | ||
| else | ||
| echo "!! $HOME/sf directory already exists. Delete it and try again." && echo 1 | ||
| fi |
There was a problem hiding this comment.
This was preventing any of the retry logic from making it past this step. Now we cleanup that dir in CI
mdonnalley
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the
promote-verifyscript. It is failing todayhttps://github.com/salesforcecli/cli/actions/runs/6723303590/job/18276144568#step:4:166