feat!: migrate to ESM #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: ESM and node 18 minimum
mshanemc
approved these changes
Oct 27, 2023
package.json
Outdated
| @@ -38,25 +36,26 @@ | |||
| "husky": "^7.0.4", | |||
| "mocha": "^9.1.3", | |||
| "nyc": "^15.1.0", | |||
| "oclif": "^3.17.2", | |||
| "oclif": "^4.0.3", | |||
| "prettier": "^2.8.8", | |||
| "pretty-quick": "^3.1.0", | |||
| "shx": "0.3.4", | |||
| "sinon": "10.0.0", | |||
| "swc": "^1.0.11", | |||
There was a problem hiding this comment.
since bin/dev is way different now, does that mean we don't need swc anymore?
|
QA: commands seem to work fine via bin/dev and bin/run When I open the new 
outside of this PR's changes: PR to this PR to fix those #673 |
* feat: finish sf-ification * chore: github cleanup
mshanemc
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate to ESM
What issues does this PR fix or reference?
@W-14374756@