feat(master): enable option to set master scheduler#484
feat(master): enable option to set master scheduler#484kartnico wants to merge 1 commit intosaltstack-formulas:masterfrom kartnico:schedule_on_master
Conversation
|
Best reviewed: commit by commit
Optimal code review plan
|
| {%- for child in children %} | ||
| {%- for key, value in child.items() %} | ||
| {{ key }}: {{ value }} | ||
| {%- endfor -%} | ||
| {%- endfor -%} |
There was a problem hiding this comment.
Maybe this for loop should be indented?
| - function: winrepo.update_git_repos | ||
| - hours: 6 |
There was a problem hiding this comment.
yamlint wants 2 more spaces here https://travis-ci.com/github/saltstack-formulas/salt-formula/jobs/375422351#L300
|
@kartnico An important point to note is that we're in the process of deprecating the configuration using |
I have no idea what this implies to users of this formula (I don't know TOFS), I hope we document clearly what are the needed changes when we decide to implement this breaking change |
@daks This is the specific comment that explains it: #398 (comment). I've now linked to it in the main comment in #417 as well. Actually, the TOFS method is much simpler than the current pillar-based method. To transfer over, you just take your existing rendered |
|
I don't like the idea of just pushing files, that's not how I imagine config management, but OK. |
4 participants
What type of PR is this?
Enable configuration of scheduling option on master : https://docs.saltstack.com/en/latest/topics/jobs/#scheduling-runners
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
#323
Describe the changes you're proposing
Take the same implementation than minion configuration file : #323
Documentation checklist
README(e.g.Available states).pillar.example.