Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Update for deprecation of hex in pygit2 1.15.0 and above #67105

Open
wants to merge 3 commits into
base: 3006.x
Choose a base branch
from

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Dec 18, 2024

What does this PR do?

Updates pygit2 support to allow from removal of support for hex in pygit2 v1.15.0 and above

What issues does thihttps://github.com/saltstack/salt/issues/67017s PR fix or reference?

Fixes #67017

Previous Behavior

Errors and traceback for unsupported hex with pygit2 v1.15.0 and above

File "/opt/saltstack/salt/lib/python3.10/site-packages/salt/utils/gitfs.py", line 2280, in find_file
    return blob, blob.hex, mode
AttributeError: '_pygit2.Blob' object has no attribute 'hex'

New Behavior

New more tracebacks and code works with pygit2 v1.15.0 and above

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Dec 18, 2024
@dmurphy18 dmurphy18 self-assigned this Dec 18, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner December 18, 2024 17:31
@dmurphy18 dmurphy18 changed the title [WIP] [3006.x] Update for deprecation of hex in pygit2 1.15.0 and above [3006.x] Update for deprecation of hex in pygit2 1.15.0 and above Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants