Fix test: tests/integration/modules/test_gem.py #67178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tests/integration/modules/test_gem.py to pass gem_binary="gem.cmd" to the gem module on windows. Although just using "gem" on the commandline works, from the module, via cmd.run_all it doesn't.
dwoz
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates tests/integration/modules/test_gem.py to pass gem_binary="gem.cmd" to the gem module on windows. Although just using "gem" on the commandline works, from the module, via cmd.run_all it doesn't.
Should possibly fix the gem module but as that is on the list for migration to a community module, I'm not going to do that now.
What issues does this PR fix or reference?
#67176
Previous Behavior
Tests failing on Windows on GH hosted runners
New Behavior
Tests passing