Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(media-server): make autoscan deployment overridable #175

Closed
wants to merge 1 commit into from

Conversation

keldian
Copy link
Contributor

@keldian keldian commented Oct 29, 2023

I figured it would be cleaner than my current solution of adding media-server to skipped tags, for skipping autoscan.

@saltydk
Copy link
Member

saltydk commented Oct 29, 2023

I'm more inclined to make it take another list so people can add/remove companion apps to it instead.

@saltydk
Copy link
Member

saltydk commented Oct 29, 2023

something along the lines of

media_servers_companion_apps_enabled: ["autoscan"]

@saltydk
Copy link
Member

saltydk commented Oct 29, 2023

That would be more along the lines of what we want to do going forward instead of having the main tags.

@keldian
Copy link
Contributor Author

keldian commented Oct 29, 2023

Sounds good. That's actually what I was entertaining at first, but then I thought there might have to be error handling involved so I opted to keep it simple.

@saltydk
Copy link
Member

saltydk commented Oct 29, 2023

Do you mind if I close this and just table it until I get around to doing the main tag workaround?

@keldian keldian closed this Oct 29, 2023
@keldian
Copy link
Contributor Author

keldian commented Oct 29, 2023

No problem.

@keldian keldian deleted the media-server branch October 29, 2023 14:14
@saltydk
Copy link
Member

saltydk commented Oct 29, 2023

I've added a feature request issue to keep track of it so I don't forget to get around to it again :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants