Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: simply workflow with a matrix #86

Merged

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Aug 11, 2023

Use a matrix to determine base distros for each job and use that to select a base container image.

sambacc/smbconf_api.py Outdated Show resolved Hide resolved
sambacc/smbconf_samba.py Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Aug 23, 2023

This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch.

@phlogistonjohn phlogistonjohn changed the title [WIP] Jjm ci cleanup workflows: simply workflow with a matrix Aug 23, 2023
@phlogistonjohn phlogistonjohn marked this pull request as ready for review August 23, 2023 17:34
@phlogistonjohn
Copy link
Collaborator Author

NOTE: This will need corresponding updates to mergify config and branch protection rules in the github ui. I'll update the mergify config in another PR and update the GUI manually after merge.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Aug 24, 2023

rebase

✅ Branch has been successfully rebased

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

Use a matrix to determine base distros for each job and use
that to select a base container image.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify
Copy link

mergify bot commented Aug 24, 2023

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn merged commit 69219eb into samba-in-kubernetes:master Sep 18, 2023
@phlogistonjohn phlogistonjohn deleted the jjm-ci-cleanup branch June 13, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants