Add push, pop, shift, & unshift functions. #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
- Coverage 94.27% 92.98% -1.29%
==========================================
Files 18 18
Lines 3178 3222 +44
==========================================
Hits 2996 2996
- Misses 170 214 +44
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Please move this work to mutable/ directory. |
samber
reviewed
Feb 16, 2025
| // Equivalent to, but more concise than: | ||
| // | ||
| // collection = append(elements, collection...) | ||
| func Unshift[T any, Slice ~[]T](collection *Slice, elements ...T) int { |
There was a problem hiding this comment.
In respect with go semantic, i would replace Push/unshift by Append/Preppend.
samber
reviewed
Feb 16, 2025
|
|
||
| func verifyNonEmpty[T any](slice []T) { | ||
| if len(slice) == 0 { | ||
| panic("Cannot remove element from empty slice!") |
There was a problem hiding this comment.
I don't really like calls to panic in such utilitary lib, any other idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows code like the following:
… which is a bit more concise than Go’s familiar
foo = append(foo, 4)idiom.If the maintainers agree that these are good additions, I’ll add tests before merging.
Thanks!