Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update dependencies #12

Closed
wants to merge 1 commit into from
Closed

go.mod: update dependencies #12

wants to merge 1 commit into from

Conversation

maruel
Copy link
Contributor

@maruel maruel commented Sep 23, 2024

This gets rid of the dependency on golang.org/x/exp by updating go.uber.org/goleak.

Side effects: updated minimum go version to 1.22.0. Seems like a new "feature" of the go1.23.1 toolchain.

Ran:

go get -u -t ./...
go mod tidy

This gets rid of the dependency on golang.org/x/exp by updating
go.uber.org/goleak.

Ran:
```
go get -u -t ./...
go mod tidy
```
@maruel
Copy link
Contributor Author

maruel commented Sep 27, 2024

I can't see what the snyk failure is. When I click on "Details", I get "You are not a member of this organization.".

@samber
Copy link
Owner

samber commented Oct 1, 2024

I will remove it. Bearer works much better IMO.

https://www.bearer.com/

@samber
Copy link
Owner

samber commented Oct 1, 2024

It seems like to goleak dependency is backward compatible with 1.20.

Why did you upgrade the min go version ?

I would like to keep the version as low as possible, for large compatbility.

Thanks for reporting the issue with golang.org/x/exp anyway. I'm going to close this PR for a new one.

@samber samber closed this Oct 1, 2024
@samber
Copy link
Owner

samber commented Oct 1, 2024

#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants