fix crash with placeholder icon cache #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how icons are handled and displayed in the DIY automation UI, making the icon rendering more robust against missing or invalid resources. It also makes a small change to the
Actioninterface for consistency.Improvements to icon handling:
AutomationItemandActionItemcomposables to ensure the icon resource is of typedrawableand to fall back to a default icon (R.drawable.rounded_do_not_disturb_on_24) if the provided icon is invalid or missing. This prevents crashes from invalid icon references and improves UI stability. [1] [2]LocalContextinAutomationItem.ktto support the new icon validation logic.Code consistency:
DimWallpaperaction inAction.ktto use property getters fortitleandiconinstead of fixed values, aligning with best practices for property initialization.