-
Notifications
You must be signed in to change notification settings - Fork 0
Prod 배포 #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Prod 배포 #299
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b972d7f
[REFACTOR] 이력서, 포트폴리오 기반 채용공고 적합도 분석을 비동기 방식으로 변경 (#288)
unifolio0 5167d01
[REFACTOR] 비동기 이력서 평가 파일을 받도록 수정 (#290)
unifolio0 e9115fe
docs: 이슈 및 pr 템플릿
unifolio0 aea0571
docs: api 문서 수정
unifolio0 c9cb79a
[REFACTOR] 비동기 이력서 평가 기능 리팩토링 (#295)
unifolio0 c11082e
refactor: Buffer 오류 수정
unifolio0 4284a2a
refactor: Buffer 오류 수정
unifolio0 e331507
refactor: bucket 수정
unifolio0 cbe1195
refactor: kokomen 에러 스택 트레이스 출력
unifolio0 2ddfaaf
refactor: redis 직렬화 오류 수정
unifolio0 86cce87
[FEAT] 저장된 이력서로 평가 API (#296)
unifolio0 84dfd25
[REFACTOR] 이력서 평가 API 형식 변경 (#298)
unifolio0 ded2289
refactor: 이력서 평가 트랜잭션 분리
unifolio0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 2 additions & 5 deletions
7
.github/ISSUE_TEMPLATE/default-request.md → .github/ISSUE_TEMPLATE/feat-request.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,12 @@ | ||
| --- | ||
| name: Default request | ||
| name: Feat request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| title: '[FEAT] ' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| # 투두 리스트 | ||
| - [ ] To-do 1 | ||
| - [ ] To-do 2 | ||
| - [ ] To-do 3 | ||
|
|
||
| # 참고 사항 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| name: Refactor request | ||
| about: Suggest an idea for this project | ||
| title: '[REFACTOR] ' | ||
| labels: '' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| # 투두 리스트 | ||
|
|
||
| # 참고 사항 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| closed # | ||
|
|
||
| # 작업 내용 | ||
| - 작업 내용 1 | ||
| - 작업 내용 2 | ||
| - 작업 내용 3 | ||
|
|
||
| # 스크린샷 | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| package com.samhap.kokomen.resume.domain; | ||
|
|
||
| import com.samhap.kokomen.global.constant.AwsConstant; | ||
| import java.util.UUID; | ||
| import lombok.Getter; | ||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.stereotype.Component; | ||
|
|
@@ -22,21 +23,21 @@ public CareerMaterialsPathResolver( | |
| this.portfolioS3Path = portfolioS3Path; | ||
| } | ||
|
|
||
| public String resolveResumeCdnPath(Long memberId, String title) { | ||
| return AwsConstant.CLOUD_FRONT_DOMAIN_URL + resumeS3Path + memberId + FOLDER_DELIMITER + title | ||
| public String resolveResumeCdnPath(Long memberId, String s3Key) { | ||
| return AwsConstant.CLOUD_FRONT_DOMAIN_URL + resumeS3Path + memberId + FOLDER_DELIMITER + s3Key | ||
| + PDF_FILE_EXTENSION; | ||
| } | ||
|
|
||
| public String resolveResumeS3Key(Long memberId, String title) { | ||
| return resumeS3Path + memberId + FOLDER_DELIMITER + title + PDF_FILE_EXTENSION; | ||
| return resumeS3Path + memberId + FOLDER_DELIMITER + title + "-" + UUID.randomUUID() + PDF_FILE_EXTENSION; | ||
| } | ||
|
|
||
| public String resolvePortfolioCdnPath(Long memberId, String title) { | ||
| return AwsConstant.CLOUD_FRONT_DOMAIN_URL + portfolioS3Path + memberId + FOLDER_DELIMITER + title | ||
| public String resolvePortfolioCdnPath(Long memberId, String s3Key) { | ||
| return AwsConstant.CLOUD_FRONT_DOMAIN_URL + portfolioS3Path + memberId + FOLDER_DELIMITER + s3Key | ||
| + PDF_FILE_EXTENSION; | ||
| } | ||
|
Comment on lines
+35
to
38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| public String resolvePortfolioS3Key(Long memberId, String title) { | ||
| return portfolioS3Path + memberId + FOLDER_DELIMITER + title + PDF_FILE_EXTENSION; | ||
| return portfolioS3Path + memberId + FOLDER_DELIMITER + title + "-" + UUID.randomUUID() + PDF_FILE_EXTENSION; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolveResumeCdnPath메소드의 구현에 버그가 있습니다.s3Key파라미터는resolveResumeS3Key메소드에서 생성된 전체 S3 객체 키(resumes/123/some-title-uuid.pdf와 같은 형식)를 전달받습니다. 하지만 현재 구현은 이 전체 키에 다시 경로와 확장자를 덧붙여 잘못된 CDN URL을 생성합니다. 예를 들어,https://.../resumes/123/resumes/123/my-resume-uuid.pdf.pdf와 같은 잘못된 URL이 만들어질 수 있습니다.s3Key가 이미 전체 경로이므로, CloudFront 도메인만 앞에 붙여주면 올바른 URL이 생성됩니다. 이 수정으로memberId파라미터가 사용되지 않게 되는데, 추후 리팩토링 시 시그니처에서 제거하는 것을 고려해 보세요.