Skip to content

HOTFIX : nginx 경로 설정 변경#195

Merged
alsgud8311 merged 1 commit intomainfrom
development
Nov 27, 2025
Merged

HOTFIX : nginx 경로 설정 변경#195
alsgud8311 merged 1 commit intomainfrom
development

Conversation

@alsgud8311
Copy link
Contributor

No description provided.

@alsgud8311 alsgud8311 merged commit 6a97e3d into main Nov 27, 2025
8 checks passed
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @alsgud8311, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 프로덕션 Docker 환경에서 Nginx 설정 파일이 잘못된 상대 경로로 인해 올바르게 로드되지 않던 중요한 문제를 해결합니다. 이 변경으로 Nginx 서비스가 설정을 올바르게 액세스할 수 있게 되어 잠재적인 배포 실패나 잘못된 구성 문제를 해결하고, 서비스의 안정적인 운영을 보장합니다.

Highlights

  • Nginx 설정 경로 수정: 프로덕션 환경의 Docker Compose 파일(docker/server/compose.prod.yaml)에서 Nginx 설정 파일(nginx.conf)의 마운트 경로가 상대 경로 오류로 인해 ./apps/kokomen-server/nginx/prod/nginx.conf에서 ../../apps/kokomen-server/nginx/prod/nginx.conf로 수정되었습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 compose.prod.yaml 파일에서 Nginx 설정 파일의 경로를 수정하여 긴급 문제를 해결합니다. docker-composedocker/server 디렉토리에서 실행되는 것을 기준으로 볼 때, 변경된 상대 경로는 올바른 수정입니다. 하지만 코드의 장기적인 유지보수성을 위해 상대 경로 사용에 대한 의견을 남겼습니다. 이 수정으로 인해 compose.local.yaml 파일과 경로 설정 방식에 불일치가 발생할 수 있으므로, 관련 파일들도 함께 점검하여 일관성을 유지하는 것을 권장합니다.

- "443:443"
volumes:
- ./apps/kokomen-server/nginx/prod/nginx.conf:/etc/nginx/nginx.conf:ro
- ../../apps/kokomen-server/nginx/prod/nginx.conf:/etc/nginx/nginx.conf:ro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

경로 수정은 올바르지만, ../../와 같은 상대 경로는 파일 구조가 변경될 때 깨지기 쉬워 유지보수성을 저해할 수 있습니다.

향후 리팩토링 시 다음과 같은 방법을 고려하여 안정성을 높일 수 있습니다:

  • docker-compose 실행 위치 변경: docker-compose 명령을 프로젝트 루트 디렉토리에서 실행하고, 모든 볼륨 경로를 ./apps/...와 같이 루트에 상대적으로 지정합니다. 이 경우 다른 compose 파일들의 build.context.으로 수정해야 합니다.
  • YAML 앵커 사용: compose 파일 상단에 프로젝트 루트를 가리키는 앵커를 정의하여 재사용할 수 있습니다.
    x-project-root: &project-root ../..
    
    services:
      nginx:
        volumes:
          - *project-root/apps/kokomen-server/nginx/prod/nginx.conf:/etc/nginx/nginx.conf:ro

이 PR은 긴급 수정이므로 현재 변경 사항은 적절하지만, 장기적인 관점에서 개선을 고려해보는 것이 좋습니다.

@github-actions
Copy link

🛠️ Build Summary

Status: ✅ SUCCESS
Duration: 60초
Exit Code: 0
Commit: 20c03e7

📋 Build Output (마지막 45줄)

├ ○ /404 (1272 ms)                         1.77 kB         315 kB
├ ○ /500 (1271 ms)                           758 B         311 kB
├ ƒ /api/auth/logout                           0 B         310 kB
├ ƒ /dashboard                             14.3 kB         637 kB
├ ƒ /interviews                            8.19 kB         349 kB
├ ƒ /interviews/[interviewId]              11.7 kB         607 kB
├ ƒ /interviews/[interviewId]/result       7.78 kB         365 kB
├ ○ /layout (1270 ms)                        540 B         311 kB
├   └ css/2af4d3721e97fa9b.css               280 B
├ ƒ /login                                 2.59 kB         315 kB
├ ƒ /login/callback                        2.01 kB         336 kB
├ ƒ /login/google/callback                 2.02 kB         336 kB
├ ƒ /login/profile                         7.65 kB         369 kB
├ ƒ /members/[memberId]                       4 kB         341 kB
├ ƒ /members/[memberId]/sitemap.xml          429 B         311 kB
├ ƒ /members/interviews/[interviewId]      6.91 kB         341 kB
├ ƒ /purchase                              7.64 kB         631 kB
├ ƒ /purchase/confirm                      1.78 kB         335 kB
├ ○ /purchase/error (1270 ms)                800 B         313 kB
├ ƒ /rank                                  3.34 kB         340 kB
├ ƒ /recruit                               7.39 kB         348 kB
├ ƒ /resume                                  865 B         438 kB
├ ƒ /resume/eval                            2.4 kB         440 kB
├ ƒ /resume/eval/demo                      2.67 kB         440 kB
├ ƒ /server-sitemap.xml                      422 B         311 kB
├ ƒ /sitemap/members.xml                     424 B         311 kB
├ ƒ /sitemap/rank.xml                        421 B         311 kB
├ ƒ /terms/privacy                         5.23 kB         339 kB
└ ƒ /terms/termsofuse                      5.06 kB         339 kB
+ First Load JS shared by all               326 kB
  ├ chunks/framework-dc17cf7945e40527.js   57.6 kB
  ├ chunks/main-41f2ddb8e08288f8.js         176 kB
  ├ chunks/pages/_app-6579d1d69d18093d.js  74.7 kB
  ├ css/8582497d0c87733e.css               15.9 kB
  └ other shared chunks (total)            1.92 kB

ƒ Middleware                               96.2 kB

○  (Static)   prerendered as static content
ƒ  (Dynamic)  server-rendered on demand

   Memory usage report:
    - Total time spent in GC: 438.15ms
    - Peak heap usage: 75.27 MB
    - Peak RSS usage: 691.84 MB

🤖 Generated by GitHub Actions at Thu Nov 27 10:27:18 UTC 2025

@github-actions
Copy link

🚀 Lighthouse Report for TEST1

📅 Date: 11/27/2025

Category Score
🔴 Performance 46
🟢 Accessibility 96
🟢 Best Practices 96
🟢 SEO 100

📊 Performance Details

Metric Score Value
🟢 First Contentful Paint 100 0.9 s
🔴 Largest Contentful Paint 17 5.6 s
🟢 Cumulative Layout Shift 100 0

🚀 Lighthouse Report for TEST2

📅 Date: 11/27/2025

Category Score
🟠 Performance 51
🟢 Accessibility 96
🟢 Best Practices 96
🟢 SEO 100

📊 Performance Details

Metric Score Value
🟢 First Contentful Paint 100 0.9 s
🔴 Largest Contentful Paint 22 5.3 s
🟢 Cumulative Layout Shift 100 0

🚀 Lighthouse Report for TEST3

📅 Date: 11/27/2025

Category Score
🟠 Performance 51
🟢 Accessibility 96
🟢 Best Practices 96
🟢 SEO 100

📊 Performance Details

Metric Score Value
🟢 First Contentful Paint 100 0.9 s
🔴 Largest Contentful Paint 18 5.6 s
🟢 Cumulative Layout Shift 100 0

🚀 Lighthouse Report for TEST4

📅 Date: 11/27/2025

Category Score
🔴 Performance 0
🟢 Accessibility 96
🟢 Best Practices 96
🟢 SEO 100

📊 Performance Details

Metric Score Value
🟢 First Contentful Paint 100 0.9 s
🔴 Largest Contentful Paint 0 undefined
🟢 Cumulative Layout Shift 100 0

🚀 Lighthouse Report for TEST5

📅 Date: 11/27/2025

Category Score
🔴 Performance 31
🟢 Accessibility 96
🟢 Best Practices 96
🟢 SEO 100

📊 Performance Details

Metric Score Value
🟢 First Contentful Paint 100 0.9 s
🔴 Largest Contentful Paint 18 5.6 s
🔴 Cumulative Layout Shift 20 0.447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant