Skip to content

[RELEASE-20251130] #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alsgud8311 merged 1 commit into from
Nov 30, 2025
Merged

[RELEASE-20251130] #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/client/src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function Home({
}: InferGetServerSidePropsType<typeof getServerSideProps>): JSX.Element {
return (
<>
<SEO robots="index, follow" />
<SEO robots="index, follow" pathname="/" />
<main className="min-h-screen">
<Header user={user} />
<section className="relative overflow-hidden pt-16 sm:pt-20 lg:pt-32">
Expand Down
12 changes: 6 additions & 6 deletions apps/client/src/shared/header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ const navigation = (isTestUser: boolean): HeaderNavigation[] => {
current: false,
featureFlag: true
},
{
href: "/recruit",
label: "채용 공고",
current: false,
featureFlag: true
},
// {
// href: "/recruit",
// label: "채용 공고",
// current: false,
// featureFlag: true
// },
Comment on lines +55 to +60
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

채용 공고 네비게이션 항목을 비활성화하기 위해 코드를 주석 처리하는 대신, 이미 존재하는 featureFlag를 사용하는 것이 더 깔끔하고 유지보수하기 좋은 방법입니다. featureFlag를 false로 설정하면 해당 항목이 렌더링되지 않도록 로직이 이미 일부 구현되어 있습니다. 이렇게 하면 기능을 다시 활성화할 때 주석을 해제하는 대신 플래그 값만 변경하면 되므로 실수를 줄일 수 있습니다.

(참고: 현재 모바일 메뉴에서는 featureFlag가 적용되지 않는 버그가 있어, 이 방법을 사용하려면 해당 버그 수정이 선행되어야 합니다. 이 내용은 종합 의견에도 남겼습니다.)

Suggested change
// {
// href: "/recruit",
// label: "채용 공고",
// current: false,
// featureFlag: true
// },
{
href: "/recruit",
label: "채용 공고",
current: false,
featureFlag: false
},

{
href: "/purchase",
label: "토큰 구매",
Expand Down