chore(Server): rename is_request_ready to validate_request

- moved the recv function to handle_connection for better logical separation
samih713 · Apr 21, 2024 · c4ef4f1 · c4ef4f1
1 parent e74242a
commit c4ef4f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sources/server/Server.cpp b/sources/server/Server.cpp
@@ -56,10 +56,9 @@ Server::~Server()
 
 /* ---------------------------- HANDLE CONNECTION --------------------------- */
 
-bool Server::is_request_ready(Request& r, fd incoming)
+bool Server::validate_request(Request& r)
 {
     try {
-        r.recv(incoming);
         if (!r.parse_request(config))
             return false;
         return true;
@@ -75,7 +74,8 @@ void Server::handle_connection(fd incoming, fd_set& activeSockets)
     ConnectionManager::check_connection(incoming);
     Request& r = ConnectionManager::add_connection(incoming, activeSockets);
     try {
-        if (!is_request_ready(r, incoming))
+        r.recv(incoming);
+        if (!validate_request(r))
             return;
 
         IRequestHandler* handler =

diff --git a/sources/server/Server.hpp b/sources/server/Server.hpp
@@ -35,7 +35,7 @@ class Server {
     const ServerConfig& config;
     CachedPages*        cachedPages;
 
-    bool is_request_ready(Request& r, fd incoming);
+    bool validate_request(Request& r);
     void handle_connection(fd incoming, fd_set& activeSockets);
     /* polling strats */
     void select_strat();