Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add translations page with dynamic seo content #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maliksvd
Copy link

📚 Description

This PR adds a translations page to demonstrate dynamic meta tag setting with i18n.

Copy link
Owner

@samk-dev samk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for the PR,

  • useSetI18nParams as shown in the screenshot Typescript complains about it being in i18n config key in nuxt.config which you can check node_modules/@nuxtjs/i18n/dist/module.d.ts on line 371 and also the docs doesn't mention that it has to be set from nuxt.config
  • The starter is using npm as package manager, which does not limit you to use other package managers when you use the starter for your projects by deleting package-lock.json and then install deps with your preferred package manager so yarn.lock is not needed here.
Screenshot 2024-06-23 at 11 02 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants