Added options to allow IDP to dynamically change values of Name ID and attributes when creating a SAML response.

[hamaron]

PR for an issue #87

[hamaron]

@mvastola Hi, MIke! Do you have any thoughts on this?

[hamaron]

@jphenow Hi! Is this something you could take a look?
I'm preparing another pull request which enables multi IDP configurations, created from this branch.
That feature was actually requested in some places such as #54, so I'd be happy to create a PR for the feature after this pull request
get merged.

[Zogoo]

I think good idea. SP initiated SAML request always have what NameID format required for response.

[Zogoo]

Looks good for me. Actually i'm was also thinking about do same thing, but i found this pull request.

[jphenow]

Yea I think this makes sense. Can merge master in and add a note to the README? I believe we have a place where you could describe this option from the controller perspective at least.

[hamaron]

@jphenow Sure thing. I'll add the description in README.

[Zogoo]

Any update?

[shaneshort]

@jphenow is this still being blocked? I can see this being super useful for me down the line :)

[mjobin-mdsol]

@Zogoo did you include this PR in your fork ?

[Zogoo]

@mjobin-mdsol I haven't merged yet, because this pull request removing that name id from SamlConfig. So, I was just using old way.

[Zogoo]

Yea I think this makes sense. Can merge master in and add a note to the README? I believe we have a place where you could describe this option from the controller perspective at least.

@jphenow, I have added a new wiki page for configurations and how to override with options in the "controller".
https://github.com/saml-idp/saml_idp/wiki/IdP_Configuration
And I realized that we already have lots of options never mentioned in the README. So, I would suggest to merge this pull request for now and later we can contribute our documents including name id overriding.
What do you think about it?

[jphenow]

Yea that makes sense - the comment was more aspirational about not getting further off on the README, but I don't think this really needs to block on those README changes

[hamaron]

Sorry, guys. It's been already 2 years since I got the homework to write the instruction in the Wiki to get this merged.
It would be nice if I could have a separate ticket to write the doc as you guys suggested.

I can resolve the conflicts of the files in a timely manner.

[Zogoo]

@jphenow, @hamaron I have resolved the conflict for this pull request. Because the conflict came from my branch and it was easier to resolve it by my side. But, could you guys also double check that I didn't do any miss.

And let's merge this pull request as soon as possible.

[LukeGuanY]

Do we have an update on this PR? We would like to set the name id dynamically. It would be very helpful.

[jphenow]

v0.14.0 released with this addition.