fix(client): use proper exception instead of assert for US endpoints #1641
+204
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The binance.us staking endpoints use
assertstatements for region validation:This is problematic because assert statements are completely disabled when running Python with the
-O(optimize) flag, which is common in production deployments. When this happens the validation silently disappears and users get confusing API errors from Binance instead of a clear client-side error.Solution
Added
BinanceRegionException- a proper exception class that:required_tld,actual_tld,endpoint_name)Changes
BinanceRegionExceptionto exceptions.py_require_tld()helper to BaseClientTesting
All 15 new tests pass. Ran linting with ruff, no issues.