Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sockets): return right headers for request upgrade #211

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

Threated
Copy link
Member

Supersedes #210

According to the spec we should return the protocol we decided on which I just called tcp and enforced the name everywhere because we don't want the client to decided as httpd for example only permits upgrades of names that it knows about:

<VirtualHost *:80>
    ProxyPass / http://broker:8080/ upgrade=tcp
    ProxyPassReverse / http://broker:8080/
</VirtualHost>

Also I improved the test a so that it works even if we run a lot of them in parallel

@Threated Threated requested a review from TKussel October 24, 2024 12:47
@Threated
Copy link
Member Author

I cherry picked my flaky tests fix from the other branch. At least one useful commit from there 😭

@Threated Threated merged commit 99a3aab into develop Oct 24, 2024
10 checks passed
@Threated Threated deleted the fix/sockets branch October 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants