Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(number input): add min and max values #100

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

MatsJohansen87
Copy link
Collaborator

@MatsJohansen87 MatsJohansen87 commented Jun 13, 2024

General Summary

min and max values can be configured

Description

the number input fields in the catalogue can have up to one minimum and up to one maximum value

Motivation and Context

the user should be prevented from entering numbers that make no sense

How Has This Been Tested?

by hand in the browser

  • The commit message follows guidelines
  • Tests for the changes have been added
  • Documentation has been added/ updated

Copy link
Contributor

@1000daysofcode 1000daysofcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatsJohansen87 MatsJohansen87 merged commit b60553d into develop Jun 13, 2024
6 checks passed
@patrickskowronekdkfz patrickskowronekdkfz deleted the feature/add-min-max-to-number-inputs branch October 8, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants