Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also replace % in aggregatedValues #214

Merged

Conversation

patrickskowronekdkfz
Copy link
Collaborator

General Summary

This PR replace subgroup placeholders in aggregateValues. This is needed for the catalogue of CCP-Explorer and future Projects

@timakro
Copy link
Collaborator

timakro commented Feb 11, 2025

Very nice change, now the % replacement is all in one place.

This means we can also get rid of this call:

criteria = getCriteria("diagnosis");

Maybe we could also completely get rid of getCritera() and its helper functions? That would only work though insofar nobody is using this interface:

export const getCriteriaAPI = (category: string): string[] => {
return getCriteria(category);
};

@patrickskowronekdkfz
Copy link
Collaborator Author

Very nice change, now the % replacement is all in one place.

This means we can also get rid of this call:

criteria = getCriteria("diagnosis");

You're right. This is then no longer needed and was only for a workaround. I will remove it.

Maybe we could also completely get rid of getCritera() and its helper functions? That would only work though insofar nobody is using this interface:

export const getCriteriaAPI = (category: string): string[] => {
return getCriteria(category);
};

I would not remove it yet. This is no longer used in the core, however it might be used in a project. Therefore I would maybe mark it as deprecated.

@timakro
Copy link
Collaborator

timakro commented Feb 12, 2025

Marking getCriteriaAPI as deprecated sounds good to me.

@patrickskowronekdkfz patrickskowronekdkfz merged commit 5979ddf into develop Feb 14, 2025
6 checks passed
@patrickskowronekdkfz patrickskowronekdkfz deleted the fix/search_in_subgroups_for_placeholders branch February 14, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants