Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a close button to close error toasts #220

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

timakro
Copy link
Collaborator

@timakro timakro commented Feb 12, 2025

image

Closes #208

Copy link
Collaborator

@patrickskowronekdkfz patrickskowronekdkfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting a Toast the underlying elements are still not accessible for the rest of the timeout. I not sure if the delete function is not working as intended or it is not updated properly

@timakro
Copy link
Collaborator Author

timakro commented Feb 13, 2025

I tested with the footer links and they work for me as soon as the fade out animation ends.

@patrickskowronekdkfz
Copy link
Collaborator

Sounds interesting, I tested it with Safari, Firefox and Chrome. On all the links were not clickable until the timeout was reached. I hope this is not a Mac OS issue. @DenisKoether could you please test if this happens on windows?

@DenisKoether
Copy link
Contributor

Sounds interesting, I tested it with Safari, Firefox and Chrome. On all the links were not clickable until the timeout was reached. I hope this is not a Mac OS issue. @DenisKoether could you please test if this happens on windows?

I had the same error Patrick, but it was just a small css issue. It should now work without problems.

@timakro
Copy link
Collaborator Author

timakro commented Feb 14, 2025

Thanks for the fix. Now I'm confused how it ever worked in my testing ^^

@patrickskowronekdkfz
Copy link
Collaborator

It might be a screen size/ resolution issue. However, thanks for fix!

@patrickskowronekdkfz patrickskowronekdkfz merged commit 92d4b5f into develop Feb 14, 2025
6 checks passed
@patrickskowronekdkfz patrickskowronekdkfz deleted the feat/allow-closing-error-toasts branch February 14, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make error toast closeable
3 participants