Changes for release v0.4.6 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to show an error to the user when the "error" event of the server sent events source fires. The error message was misleading because it indicated that the error originated from beam, whereas the "error" event only indicates that the server sent events stream was interrupted. When the stream is interrupted the server sent events source tries to reconnect after firing the "error" event. In our case where the server sents events connection is rather short lived (only until we got results from all sites) it makes sense to treat an interruption of the stream as indication that the server closed the connection and not try to reconnect. In fact, there was already a second event handler for the "error" event that did exactly that. So this commit removes the first event handler that shows the error to the user and keeps the second as it was.
chore: restore old structure of the empty query
fix: don't show beam error to user
fix: fix that the query modified dialog was not shown when clearing the search bar
Chore/fix vite warning
chore: remove problematic CQL line from patientsMeasure
… options in options schema
…-to-options-schema fix: add missing fields "site_id" and "collection_name" to negotiator…
…-css chore: remove fragment-development.css
…holders feat: also replace % in aggregatedValues
feat: add a close button to close error toasts
…options BREAKING CHANGE: If you have "negotiateOptions" in your lens options, you must add a key "authorizationHeader" under "negotiateOptions" that contains the value of the HTTP Authorization header (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization), e.g. "Basic <base64string>"
…iate-button> component BREAKING CHANGE: If you are using <lens-negotiate-button> in your application change the value of the "type" prop to "Negotiator" if it was "bbmri" before or to "ProjectManager" if it was "ccp" before.
….siteMappings in lens options
chore: deprecate getCriteriaAPI
…or-handling feat: improve BBMRI negotiator error handling and do some cleanup
BREAKING CHANGE: The type definition of the `Status` type changed slightly. If you are reading or writing the ResponseStore you may have to adjust your code.
chore: turn Status into a tagged union
feat: add message for empty charts
chore: remove nodeType from AST
chore: update/correct ccp catalogue
torbrenner
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Summary
Changes for Version v0.4.6