Skip to content

Fixed keyboard shortcuts not triggering early-listeners #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixed keyboard shortcuts not triggering early-listeners #1346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a85b5
Fixed keyboard shortcuts not triggering early-listeners
gurupras Mar 31, 2020
e3cf515
Incorporated reviews and fixed coding standards violations
gurupras Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/js/listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ class Listeners {
// Seek by the number keys
const seekByKey = () => {
// Divide the max duration into 10th's and times by the number value
player.currentTime = (player.duration / 10) * (code - 48);
const target = (player.duration / 10) * (code - 48);
this.proxy(event, () => {
player.currentTime = target
}, 'seek')
};

// Handle the key on keydown
Expand Down Expand Up @@ -100,52 +103,56 @@ class Listeners {
case 75:
// Space and K key
if (!repeat) {
silencePromise(player.togglePlay());
this.proxy(event, () => silencePromise(player.togglePlay()), 'play');
}
break;

case 38:
// Arrow up
player.increaseVolume(0.1);
this.proxy(event, () => player.increaseVolume(0.1), 'volume');
break;

case 40:
// Arrow down
player.decreaseVolume(0.1);
this.proxy(event, () => player.decreaseVolume(0.1), 'volume');
break;

case 77:
// M key
if (!repeat) {
player.muted = !player.muted;
this.proxy(event, () => {
player.muted = !player.muted
}, 'mute')
}
break;

case 39:
// Arrow forward
player.forward();
this.proxy(event, player.forward, 'fastForward');
break;

case 37:
// Arrow back
player.rewind();
this.proxy(event, player.rewind, 'rewind');
break;

case 70:
// F key
player.fullscreen.toggle();
this.proxy(event, player.fullscreen.toggle, 'fullscreen');
break;

case 67:
// C key
if (!repeat) {
player.toggleCaptions();
this.proxy(event, player.toggleCaptions, 'captions');
}
break;

case 76:
// L key
player.loop = !player.loop;
this.proxy(event, () => {
player.loop = !player.loop
}, 'loop')
break;

/* case 73:
Expand All @@ -167,7 +174,7 @@ class Listeners {
// Escape is handle natively when in full screen
// So we only need to worry about non native
if (code === 27 && !player.fullscreen.usingNative && player.fullscreen.active) {
player.fullscreen.toggle();
this.proxy(event, player.fullscreen.toggle, 'fullscreen');
}

// Store last code for next cycle
Expand Down