-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An issue with the Basement preprocessor has been fixed #510
Merged
samuelduchesne
merged 19 commits into
develop
from
feature/508-basement-preprocessor-seems-to-fail-
Sep 21, 2024
Merged
An issue with the Basement preprocessor has been fixed #510
samuelduchesne
merged 19 commits into
develop
from
feature/508-basement-preprocessor-seems-to-fail-
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…505) * adds IDF.copy() and IDF.saveas(inplace=True) (#254) * Adjusts svg repr to the min/max values of the schedule (#255) * Graceful warning when Slab or Basement program is not found * Adds KeyBoardInterupt to IDF Thread * catches more variations of unit name * Adds ability to scale a schedule * Fixes fallback limits for Schedule.plot2d() when Type is not defined * Type can be specified in Schedule.from_values constructor * plot2d is prettier by default * more Typing * Return existing object when new_object is there (#257) * Adds ability to replace schedule values without affecting the full load hours * more robust IDF.name property * Keep sim files when error occurs (#276) * updates requests requirement from ~=2.25.1 to >=2.26 (#292) * typo * this * gitsubmodule as https * p * pp * this * error * catch outfile * logging * Revert "logging" This reverts commit bef3e4b. * keep * as model * better logging * comments --------- Co-authored-by: Samuel Letellier-Duchesne <samueld@mit.edu> Co-authored-by: Zach Berzolla <53047789+zberzolla@users.noreply.github.com>
…e from specified version
This is working for me with a caveat: EnergyPlus 9.5 sometimes fails the Basement PreProcessor due to a fortran error. Interestingly, this seems to be caused by the weather file rather than the idf. here's a demo with the same IDF, but two different weather files: Pretty sure its this issue, so not an archetypal problem. |
samuelduchesne
deleted the
feature/508-basement-preprocessor-seems-to-fail-
branch
September 21, 2024 18:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.