Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An issue with the Basement preprocessor has been fixed #510

Merged

Conversation

samuelduchesne
Copy link
Owner

No description provided.

samuelduchesne and others added 5 commits July 21, 2024 09:50
…505)

* adds IDF.copy() and IDF.saveas(inplace=True) (#254)

* Adjusts svg repr to the min/max values of the schedule (#255)

* Graceful warning when Slab or Basement program is not found

* Adds KeyBoardInterupt to IDF Thread

* catches more variations of unit name

* Adds ability to scale a schedule

* Fixes fallback limits for Schedule.plot2d() when Type is not defined

* Type can be specified in Schedule.from_values constructor

* plot2d is prettier by default

* more Typing

* Return existing object when new_object is there (#257)

* Adds ability to replace schedule values without affecting the full load hours

* more robust IDF.name property

* Keep sim files when error occurs (#276)

* updates requests requirement from ~=2.25.1 to >=2.26 (#292)

* typo

* this

* gitsubmodule as https

* p

* pp

* this

* error

* catch outfile

* logging

* Revert "logging"

This reverts commit bef3e4b.

* keep

* as model

* better logging

* comments

---------

Co-authored-by: Samuel Letellier-Duchesne <samueld@mit.edu>
Co-authored-by: Zach Berzolla <53047789+zberzolla@users.noreply.github.com>
@samuelduchesne samuelduchesne added the bug Something isn't working label Sep 20, 2024
@szvsw
Copy link
Collaborator

szvsw commented Sep 21, 2024

This is working for me with a caveat:

EnergyPlus 9.5 sometimes fails the Basement PreProcessor due to a fortran error. Interestingly, this seems to be caused by the weather file rather than the idf.

here's a demo with the same IDF, but two different weather files:

basement_test_ak.zip

Pretty sure its this issue, so not an archetypal problem.

NREL/EnergyPlus#8333

@samuelduchesne samuelduchesne merged commit 2c895fe into develop Sep 21, 2024
5 checks passed
@samuelduchesne samuelduchesne deleted the feature/508-basement-preprocessor-seems-to-fail- branch September 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants