Draw deprecated references #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than doubling up
euglena1215
added a commit
to euglena1215/graphwerk
that referenced
this pull request
Nov 20, 2023
A change was made at samuelgiles#7 to draw deprecated dependencies, now named `package_todo.yml` instead of `deprecated_references.yml`. I thought about renaming `DeprecatedReferencesLoader`, but if people are still using the old packwerk, it would be a breaking change, so I added the `PackageTodoLoader` instead of renaming it.
euglena1215
added a commit
to euglena1215/graphwerk
that referenced
this pull request
Nov 21, 2023
A change was made at samuelgiles#7 to draw deprecated dependencies, now named `package_todo.yml` instead of `deprecated_references.yml`. I thought about renaming `DeprecatedReferencesLoader`, but if people are still using the old packwerk, it would be a breaking change, so I added the `PackageTodoLoader` instead of renaming it.
samuelgiles
pushed a commit
that referenced
this pull request
Jan 29, 2024
A change was made at #7 to draw deprecated dependencies, now named `package_todo.yml` instead of `deprecated_references.yml`. I thought about renaming `DeprecatedReferencesLoader`, but if people are still using the old packwerk, it would be a breaking change, so I added the `PackageTodoLoader` instead of renaming it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an idea raised in #6 where it was suggested that drawing deprecated references would be useful in helping reveal issues in an application's architecture.
Red arrows now indicate a deprecated reference from one package to another, in the above example our images component is referencing a class in the Application.