fix: prefer native chrome.i18n when available

samuelmaddock · Dec 15, 2024 · 007410b · 007410b
1 parent aef2717
commit 007410b
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/electron-chrome-extensions/src/renderer/index.ts b/packages/electron-chrome-extensions/src/renderer/index.ts
@@ -329,10 +329,16 @@ export const injectExtensionAPIs = () => {
       },
 
       i18n: {
+        shouldInject: () => manifest.manifest_version === 3,
         factory: (base) => {
+          // Electron configuration prevented this API from being available.
+          // https://github.com/electron/electron/pull/45031
+          if (base.getMessage) {
+            return base
+          }
+
           return {
             ...base,
-            // TODO(mv3): implement
             getUILanguage: () => 'en-US',
             getAcceptLanguages: (callback: any) => {
               const results = ['en-US']