fix: use createWindow option

samuelmaddock · Sep 28, 2024 · 0d696aa · 0d696aa
1 parent 620bc67
commit 0d696aa
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/packages/shell/browser/main.js b/packages/shell/browser/main.js
@@ -297,17 +297,15 @@ class Browser {
         case 'foreground-tab':
         case 'background-tab':
         case 'new-window': {
-          // setWindowOpenHandler doesn't yet support creating BrowserViews
-          // instead of BrowserWindows. For now, we're opting to break
-          // window.open until a fix is available.
-          // https://github.com/electron/electron/issues/33383
-          queueMicrotask(() => {
-            const win = this.getWindowFromWebContents(webContents)
-            const tab = win.tabs.create()
-            tab.loadURL(details.url)
-          })
-
-          return { action: 'deny' }
+          return {
+            action: 'allow',
+            createWindow: () => {
+              const win = this.getWindowFromWebContents(webContents);
+              const tab = win.tabs.create();
+              tab.loadURL(details.url);
+              return tab.webContents;
+            }
+          }
         }
         default:
           return { action: 'allow' }