Conversation
|
hi @samuong, will you be able to review this anytime soon? |
|
hi @m04f, thanks for contributing! sorry i'm so late in replying to this, but i'll try to find some time over the holidays to go over this. in the meantime, i'm curious to learn a bit more about what your intended use case for socks is? fyi there was some previous discussion in #153 and one thing we noted was that socks is useful for udp tunnelling, but the library that was being used won't support udp (see #153 (comment) for a link) i noticed in the readme for https://github.com/things-go/go-socks5 that it references "original armon's go-sock5 library", do you know if this library has the same limitation? |
|
I use SSH SOCKS5 forwarding to access a jump server, so I need Alpaca to support SOCKS5 in PAC files. Unlike previous pr (which tried to add a SOCKS server), this PR just adds basic client support. Also, things-go/go-socks5 is only used in the test suite, not in the main binary. sorry for replying this late |
This pull request adds very basic support for SOCKS5 proxies to Alpaca.
The following changes are included:
The changes have been tested and are working as expected.
Note: This is a very basic implementation and has the following limitations: