🐛 Fix importing CSV as attachment #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkkwang
force-pushed
the
i989-fix-importing-csv-as-attachment
branch
2 times, most recently
from
e919617 to
618345e
Compare
Prior to this commit, if an importer has a CSV file as an attachment, the importer would fail because it would try to parse the attached CSV as the importer CSV. This commit will add a condition to only look for a CSV file that is NOT in the `/files` directory. Ref: - #989
kirkkwang
force-pushed
the
i989-fix-importing-csv-as-attachment
branch
from
618345e to
0de575d
Compare
orangewolf
approved these changes
Jan 22, 2025
kirkkwang
added a commit
to samvera/hyku
that referenced
this pull request
Jan 22, 2025
This commit will update Bulkrax for a fix on CSV as attachments. Ref: - samvera/bulkrax#1009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if an importer has a CSV file as an attachment, the importer would fail because it would try to parse the attached CSV as the importer CSV. This commit will add a condition to only look for a CSV file that is NOT in the
/filesdirectory.Ref: