Strip out all special characters from csv headers #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Today is the day
…inate with ajax updates
…at generators work
…d unicode items, including the unicode bom, laying around. This causes havic. By stopping it right from the start we should prevent saving invisible characters to raw_metadata and other places they get stuck
orangewolf
force-pushed
the
strippers_and_rob_both_work_late
branch
from
ea238d6 to
1adeff0
Compare
jeremyf
reviewed
Feb 8, 2024
| def self.read_data(path) | ||
| raise StandardError, 'CSV path empty' if path.blank? | ||
| options = { | ||
| headers: true, | ||
| header_converters: ->(h) { h.to_s.strip.to_sym }, | ||
| header_converters: ->(h) { h.to_s.gsub(/[^\w\d -]+/, '').strip.to_sym }, |
There was a problem hiding this comment.
Do we want underscore as well?
There was a problem hiding this comment.
@jeremyf \w includes underscore.
* main: Denormalize Status Message to that Entry Look Up Can Be Fast (#913) ⚙️ Adding dry-monads as development dependency
|
closing this one for #918 instead as it is a cleaner PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cause nothing but pain.