Skip to content

Commit

Permalink
revert fix unrelated to this PR and add FIXME note
Browse files Browse the repository at this point in the history
  • Loading branch information
bkiahstroud committed Nov 20, 2024
1 parent f0efedf commit 7802691
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion app/views/shared/_settings.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
<% if value[:type] == 'array' %>
<% @account.send(key).each do |sub_value| %>
<%# FIXME:
I think current_account here should be @account. @account is present both within the tenant
as well as in the proprietor views, while current_account is only present within a tenant.
Changing it to @account causes a spec in spec/features/accounts_spec.rb to fail, I think due
to the form sending inputs that should be treated as arrays as strings.
@see AccountSettings#validate_email_format
%>
<% current_account.send(key).each do |sub_value| %>
<%= f.input key, value: sub_value %>
<% end %>
<% elsif value[:type] == 'hash' %>
Expand Down

0 comments on commit 7802691

Please sign in to comment.