🎁 Add branding persistent volumes to deploys #2219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
force-pushed
the
add-branding-volume
branch
from
80c10f1 to
d6f9429
Compare
26 tasks
ShanaLMoore
force-pushed
the
add-branding-volume
branch
from
d6f9429 to
938746b
Compare
…from the Collections' branding tab. Because the symlink wasn't established, a user would not be able to see the images they uploaded even though the path correctly exists. ref: - notch8/atla-hyku#187
ShanaLMoore
force-pushed
the
add-branding-volume
branch
from
dd03dee to
6181474
Compare
…from the Collections' branding tab. Because the symlink wasn't established, a user would not be able to see the images they uploaded even though the path correctly exists. ref: - notch8/atla-hyku#187
…into add-branding-volume
This commit is implemented following the precendence set by collection branding's banner and logo uploads. TODO: - add and update specs - attach image to collection thumbnails - thumbnails should link to the associated collection
This commit will make the collection thumbnails show up in the views such as in the dashboard list of collections and also in the catalog search results. The gitignore was updated to ignore the path where the thumbnails are stored.
This commit will fix a bug where if the user sets the thumbnail first and then later sets the alt text, they would have to have to remove the thumbnail and re-add it and set the alt text at the same time to get the alt text to be set.
This commit will add a rake task to migrate the Hyku Commons collection thumbnails which uses the /uploads/uploaded_collection_thumbnails/ path as opposed to a downloads controller endpoint.
This commit will address the code review comments with the following: - remove the /uploads gitignore, turns out there was a deeper issue with where collection branding files were being saved - remove a stray comment - remove an unnecessary TODO - remove an unnecessary method definition in the new rake task
…from the Collections' branding tab. Because the symlink wasn't established, a user would not be able to see the images they uploaded even though the path correctly exists. ref: - notch8/atla-hyku#187
…into add-branding-volume
|
The file displays now, but... Thumbnail is still missing: 
|
|
The thumbnail path needs to be TODOremove the app/samvera/ from the beginning of it |
Updates the my collection list view to match the index view. The index list view was correctly rendering thumbnails while the my list view was not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection thumbnail would not display, even though it referenced the correct path. Perhaps we need to add a persistent volume. I will test this branch to verify that it works.
BEFORE
AFTER
NOTES
This has issue has been seen and solve in other projects.
ref:
This commit is required to resolve the issue with uploading images from the Collections' branding tab. Because the symlink wasn't established, a user would not be able to see the images they uploaded even though the path correctly exists.